Rust client: Request sync lines as BSON #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on powersync-ja/powersync-service#310 and requests sync lines in a binary format when the Rust client is used.
We still support the sync service responding with text lines, but the response handling now supports splitting the BSON stream and sends that as a preference to ensure we can handle binary data. This makes the Dart SDK ready for binary data without relying on RSocket, which is poorly supported on Dart.
I've tested this with the sync service from the linked PR, and I've also expanded all sync unit tests to include the binary stream. I've also tested this PR with an old sync service, and
mainwith the new sync service to make sure content negotiation works like it's supposed to.